NXPY-269: Fix functional test#331
Merged
S-Ghosh-Dev2 merged 1 commit intowip-NXPY-270-upgrade-python-versionfrom Mar 27, 2026
Merged
NXPY-269: Fix functional test#331S-Ghosh-Dev2 merged 1 commit intowip-NXPY-270-upgrade-python-versionfrom
S-Ghosh-Dev2 merged 1 commit intowip-NXPY-270-upgrade-python-versionfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the functional tests GitHub Actions workflow to use correct YAML syntax for branch filters, bump the Python test version to 3.13.1, and simplify the Codecov conditional expression; the changelog file is touched but has no visible content changes in the diff. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Using
if: ${{ success() || failure() }}is redundant in GitHub Actions and won’t run on cancelled workflows; if the intent is to always upload coverage when the job completes, consider usingif: ${{ always() }}instead. - Before pinning to Python
3.13.1only, verify that all tools invoked in the workflow (tox envs, dependencies, and Nuxeo client versions) are compatible with 3.13; if not, you may want to keep a lower stable version in the matrix alongside 3.13 or pin to3.13instead of a specific patch.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `if: ${{ success() || failure() }}` is redundant in GitHub Actions and won’t run on cancelled workflows; if the intent is to always upload coverage when the job completes, consider using `if: ${{ always() }}` instead.
- Before pinning to Python `3.13.1` only, verify that all tools invoked in the workflow (tox envs, dependencies, and Nuxeo client versions) are compatible with 3.13; if not, you may want to keep a lower stable version in the matrix alongside 3.13 or pin to `3.13` instead of a specific patch.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Updates CI configuration to resolve functional test execution issues and records the change in the changelog.
Changes:
- Adjust
pull_requestbranch filter syntax in the functional tests workflow. - Update the functional tests workflow to run on Python
3.13.1(matching the repo’s declared supported versions intox.ini). - Minor workflow expression cleanup for the Codecov upload condition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CHANGELOG.rst |
Adds the NXPY-269 entry documenting the functional test fix. |
.github/workflows/functional_tests.yml |
Updates PR trigger syntax, bumps Python version to 3.13.1, and simplifies the Codecov if expression. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gitofanindya
approved these changes
Mar 27, 2026
S-Ghosh-Dev2
merged commit 1a30cd0
into
wip-NXPY-270-upgrade-python-version
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update functional test GitHub Actions workflow configuration to use the latest supported Python version and correct conditional and branch syntax.
CI: